Open
Conversation
Author
|
6e41361 uses |
Owner
|
Well, unfortunatelly, I have almost no time to properly test that all, but at quick look, it looks very good. Although, it would be nice to add some warning to readme about (potentially) breaking change in API. If I'll be lucky, I'll try to merge this at weekend (but can't promise) |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds text content as children nodes to the parent node, e.g.
<p>Hello<br>World</p>will parse to apnode with 3 children: a text node containingHello, thebrnode, and a text node containingWorld. A text node hasnilas its tagname (because it has no tagname), but we can discuss this choice. The added and modified tests give some sense of the new behavior.This is similar to #49 with a few differences:
nilas tagname which will never create collisions<p>Hello<br>World</p>